[PATCH] act: fix the logic of parsing actions

Thomas Haller thaller at redhat.com
Tue Jun 10 10:19:55 PDT 2014


On Mon, 2014-06-09 at 21:41 +0100, Thomas Graf wrote:
> On 04/14/14 at 06:39pm, Cong Wang wrote:
> > It is proved that actions are not always put from 0,
> > they could be discontinuous.
> > 
> > Signed-off-by: Cong Wang <xiyou.wangcong at gmail.com>
> 
> Cong is obviously right that we cannot assume order 0 and thus the
> fix is valid. However, I also agree with Thomas that we are changing
> behaviour here, at least slightly. I couldn't find a reason why that
> is a problem in this case though.
> 

Hi,


I agree, that the parsing is currently wrong.

I just have my doubts, that new solution is correct, because we loose
the "order". But probably we really don't need that piece of
information...

Since I don't have a better suggestion at the moment, lets improve the
situation from "not working" to "(probably) working":
https://github.com/thom311/libnl/commit/6608cd5d7242a8b58e62208e71b6c276434566ec


Thomas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20140610/85ce5d8b/attachment.sig>


More information about the libnl mailing list