[PATCH] Conntrack Dump ICMP

Rich Fought Rich.Fought at watchguard.com
Thu Oct 4 17:55:36 EDT 2012


Looks like a cut and paste oversight ...

diff --git a/lib/netfilter/ct_obj.c b/lib/netfilter/ct_obj.c
index d5cd18a..4686170 100644
--- a/lib/netfilter/ct_obj.c
+++ b/lib/netfilter/ct_obj.c
@@ -121,10 +121,10 @@ static void dump_icmp(struct nl_dump_params *p, struct nfnl_ct *ct, int reply)
        if (nfnl_ct_test_icmp_type(ct, reply))
                nl_dump(p, "icmp type %d ", nfnl_ct_get_icmp_type(ct, reply));
 
-       if (nfnl_ct_test_icmp_type(ct, reply))
+       if (nfnl_ct_test_icmp_code(ct, reply))
                nl_dump(p, "code %d ", nfnl_ct_get_icmp_code(ct, reply));
 
-       if (nfnl_ct_test_icmp_type(ct, reply))
+       if (nfnl_ct_test_icmp_id(ct, reply))
                nl_dump(p, "id %d ", nfnl_ct_get_icmp_id(ct, reply));
 }



More information about the libnl mailing list