[PATCH] Bug Fix: Add new fill socket to cache manager

Thomas Graf tgraf at suug.ch
Mon Nov 19 04:19:17 EST 2012


On 11/18/12 at 10:14pm, roopa at cumulusnetworks.com wrote:
> From: roopa <roopa at cumulusnetworks.com>
> 
> This patch adds a new socket to cache manager to request fill's on.
> cache manager today uses cm_sock to request dump from
> the kernel. It also listens to netlink async events on the same sock.
> The problem with this is that when libnl is waiting to process the
> response to get dump request sent to the kernel during fill,
> it may receive an async event, resulting in libnl complaining about
> unexpected msg
> 
> This is usually reproducible when there is heavy netlink async event
> traffic during nl_cache_mngr_add.
> 
> This patch adds a new cm_sync_sock to use for fill during cache manager
> add cache.
> 
> The other option is to provide an api to set the cm_sync_sock. But since
> this is a bug fix its probably better to fix the cache manager add api
> like this patch does. Please suggest otherwise.
> 
> Signed-off-by: Roopa Prabhu <roopa at cumulusnetworks.com>
> Reviewed-by: Nolan Leake <nolan at cumulusnetworks.com>
> Reviewed-by: Shrijeet Mukherjee <shm at cumulusnetworks.com>

Applied, thanks much.



More information about the libnl mailing list