[PATCH v2] Add AF_BRIDGE support to link cache

[Thomas Graf]

On 11/14/12 at 06:06am, roopa at cumulusnetworks.com wrote:
> From: roopa <roopa at cumulusnetworks.com>
> 
> This patch was previously submitted as the first approach in
> RFC http://lists.infradead.org/pipermail/libnl/2012-November/000730.html
> 
> It adds support for AF_BRIDGE family in link cache.
> And the key for link object lookups will now be ifindex and family.
> 
> This allows for AF_UNSPEC rtnl link objects to co-exist with the AF_BRIDGE
> link objects in the same cache.
> 
> I have changed some of the rtnl_link api's to explicitly check for
> AF_UNSPEC to not break existing apps. I will submit a new patch to
> introduce equivalent rtnl_bridge_link_* api's.
> 
> We had also discussed updating the existing link objects with
> AF_BRIDGE attributes, but realized that the updates to link objects will
> be both AF_UNSPEC and AF_BRIDGE. And that would change link cache to always
> update existing objects, resulting in comparing and updating close to
> thirty attributes at cache_include time which seems like a overkill.
> 
> Signed-off-by: Roopa Prabhu <roopa at cumulusnetworks.com>
> Reviewed-by: Nolan Leake <nolan at cumulusnetworks.com>
> Reviewed-by: Shrijeet Mukherjee <shm at cumulusnetworks.com>
> Reviewed-by: Wilson Kok <wkok at cumulusnetworks.com>

Applied, thanks!

We may eventually need to add a flag to each af_group entry to
separate the iterate refill feature from the groups needed to
keep cache manager synced but for now this works out great.