libnl 3.2.8

[Brett Ciphery]

[Re: libnl 3.2.8] On 08/05/2012 (Tue 09:07) Thomas Graf wrote:

> On Mon, May 07, 2012 at 07:58:54PM -0600, Justin Mayfield wrote:
> > Thomas,
> > 
> > If you don't want to revert the API change then you might try the
> > attached patch.  It seemed to cover the main trouble spot as far as
> > my grep skills could uncover.
> > 
> > Thanks,
> > Justin Mayfield
> 
> > diff --git a/include/netlink-local.h b/include/netlink-local.h
> > index 01c611a..9544d29 100644
> > --- a/include/netlink-local.h
> > +++ b/include/netlink-local.h
> > @@ -194,8 +194,10 @@ static inline int wait_for_ack(struct nl_sock *sk)
> >  {
> >  	if (sk->s_flags & NL_NO_AUTO_ACK)
> >  		return 0;
> > -	else
> > -		return nl_wait_for_ack(sk);
> > +	else {
> > +		int err = nl_wait_for_ack(sk);
> > +		return (err < 0) ? err : 0;
> > +	}
> >  }
> 
> Thanks Justin,
> 
> I think the above won't be enough as the change also seems to have
> broken applications directly. I'm considering to push the following
> fix into the tree. Is this acceptable for everyone?
> 

The change looks like it should work for the problem case I mentioned a few
weeks ago.  In the end I actually abandoned the cache manager and
used/populated a standalone cache using the ops, so I didn't get a
chance to test your original fix.

Brett