Bug in HTB prio

Thomas Graf tgraf at infradead.org
Fri Aug 12 07:49:34 EDT 2011


On Fri, Aug 12, 2011 at 11:31:45AM +0200, spidla wrote:
> Hi,
> I think I have just found a bug in HTB class prio setting. In file
> lib/route/qdisc/htb.c in function htb_class_msg_fill there is an if
> block, which sets the prio parameter into the opts object. But right
> after this section there is a memset function which actually clears
> the opts object and the prio setting is discarded. The resolution of
> this bug is to move the memset function before the if block.
> Everything is fine then.

Good catch, just fixed this in:

commit 4be7adbb71b3f4f31aecb46c9dbfaa4b1fa45009
Author: Thomas Graf <tgraf at suug.ch>
Date:   Fri Aug 12 13:47:23 2011 +0200

    htb: fix misplaced memset() overwriting already set htb prio option
    
    Reported by Richard Cesar <spidla at spidlas.cz>




More information about the libnl mailing list