src/nf-queue: revert nonsensical change

Thomas Graf tgraf at infradead.org
Thu Oct 28 19:01:04 EDT 2010


On Mon, Oct 25, 2010 at 05:32:23PM +0200, Patrick McHardy wrote:

> commit 2ae0a40a473ca4328d8b4baaff9eadfd8e56a220
> Author: Patrick McHardy <kaber at trash.net>
> Date:   Mon Oct 25 17:29:45 2010 +0200
> 
>     src/nf-queue: revert nonsensical change
>     
>     The only part of commit d378220c (src/nf-queue.c: cleanup and improve
>     performance of test program for NF_QUEUE) that actually makes sense is
>     the increase in receive buffer size. Issuing verdicts for IDs not delivered
>     to userspace is a wasted effort since the kernel drops packets itself when
>     netlink message delivery fails. This would actually have been noticed
>     by a return value of -ENOENT if the result of nfnl_queue_msg_send_verdict()
>     would have been checked.

Applied, thanks Patrick!



More information about the libnl mailing list