Thinking of glib's GObject (and) Introspection API

[Milan Crha]

On Wed, 2016-05-04 at 13:43 -0400, Allen Winter wrote:
> committed.
> I've been doing some cleanups and also getting it to build on travis.

	Hi,
thanks. I attached two more patches here, which resulted after my build
with mingw under Windows. You fixed one issue with your clean-up when
you replaced the stpcpy with g_stpcpy, then there left:

0001) incorrect includes in the libical-glib src-generator
0002) the gmtime_r is not available on windows, thus fallback to
      gmtime there; the HAVE_GMTIME_R in config.h is not defined,
      as expected, only the code doesn't check for it; evolution-
      data-server contains a similar change which works fine

With these patches I can build libical with libical-glib in mingw on
windows and compile a simple test program there as well, which runs
properly. I do not build introspection neither gtk-doc under windows,
which I believe is fine, because none of the two is the target for
windows.

> But the Mac builds have been failing on Travis:
> Milan, Miao: could see about all the warnings and errors reported at 
> https://travis-ci.org/libical/libical/jobs/127852561

I briefly looked into the log and apart of the picky warnings it seems
it's unhappy in the gtk-doc build, it looks like the reference to
>   http://docbook.sourceforge.net/release/xsl/current/html/chunk.xsl
is not correct. I searched my sources (and the build directory) and I
do not see any such chunk.xsl here, thus it can come from the gtk-doc
itself. Searching the Internet gave:
https://github.com/Homebrew/legacy-homebrew/issues/45020
and
https://mail.gnome.org/archives/xml/2008-November/msg00034.html
as two possible related issues with suggested fixes.

	Hope it helps,
	Milan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Correct-includes-in-the-libical-glib-source-generato.patch
Type: text/x-patch
Size: 1247 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20160504/b13942e5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fallback-to-gmtime-when-gmtime_r-is-not-available.patch
Type: text/x-patch
Size: 2954 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20160504/b13942e5/attachment-0001.bin>