Thinking of glib's GObject (and) Introspection API

[Allen Winter]

Thanks Milan,
Looks really good now.


On Tuesday, June 14, 2016 10:15:47 AM Milan Crha wrote:
> On Mon, 2016-06-13 at 17:15 -0400, Allen Winter wrote:
> > I'm still seeing a lot of -Wtypedef-redefinition warnings with clang.
> > See https://travis-ci.org/libical/libical/jobs/137352663
> 
> 	Hi,
> interesting, my clang has default standard higher than yours (or that
> in travis), thus I didn't see those warnings here. I added -ansi to the
> CFLAGS (which also introduced new warnings about "//" comment in the C
> files elsewhere than in libical-glib), and I get those type
> redefinition warnings too now.
> 
> The attached patch introduces a new i-cal-forward-declarations.h file
> and uses it around the sources. It's generated in a similar way as the
> other files in the libical-glib.
> 
> I chose this approach also to have nice type names in the public header
> files, thus instead of:
> 
>    struct _ICalSomeType;
>    ...
>    void i_cal_function (..., struct _ICalSomeType *x, ...);
> 
> the type can be used directly (in the nice way):
> 
>    void i_cal_function (..., ICalSomeType *x, ...);
> 
> 	Bye,
> 	Milan