Static code analyse of the libical library

[Allen Winter]

On Friday, June 03, 2016 01:15:24 AM Milan Crha wrote:
> 	Hello,
> I'd like to ask, whether you'd be interested in a static code analyse
> of the libical library. I've an access to a Coverity Scan, clang, gcc
> and cppcheck static analyse and it seems to produce very interesting
> results. A little sample can be found at the end of this email.

absolutely, in fact read this => https://github.com/libical/libical/wiki/For-the-Developers:-Code-Quality

I already run Coverity sometimes see https://scan8.coverity.com/reports.htm#v16495/p10812
I can invite you there

Since this is C code I run splint and not cppcheck.  well there is a little C++ so feel free to run cppcheck if you want.

> 
> If you are interested in it, which commit and branch you'd prefer to
> have this run on? The thing is that with the special memory management
> of the libical (or due to some other reasons) there can be many false
> positives. Thus better to focus on some fresh code. I didn't went
> through the log in detail, as it's long (the 'glib' branch for me).

Yes please. the glib branch is fine.

> 	Bye,
> 	Milan
> 
> Error: IDENTIFIER_TYPO: [#def96]
> libical-2.0.0/src/python/Collection.py:116: identifier_typo: Using "remove_componet" appears to be a typo:
> * Identifier "remove_componet" is only known to be referenced here, or in copies of this code.
> * Identifier "remove_component" is referenced elsewhere at least 10 times.
> libical-2.0.0/src/python/Collection.py:111: identifier_use: Example 1: Using identifier "remove_component".
> libical-2.0.0/src/python/test.py:564: identifier_use: Example 4: Using identifier "remove_component".
> libical-2.0.0/src/test/libical-glib/component.py:205: identifier_use: Example 5: Using identifier "remove_component".
> libical-2.0.0/src/python/Collection.py:116: remediation: Should identifier "remove_componet" be replaced by "remove_component"?
> #  114|   
> #  115|       def __delitem__(self, i):
> #  116|->         self._parent.remove_componet(self._components[i])
> #  117|           del self._components[i]
> #  118|   
> 
> 
> _______________________________________________
> libical-devel mailing list
> libical-devel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/libical-devel