[Freeassociation-devel] Problems with un-escaped characters in TZID

Wilfried Goesgens room_freeassociation-devel at uncensored.citadel.org
Wed Jan 6 15:23:37 PST 2010


hm, It seems as if my reply was aten:  

Brad, I think its patch messing up the utf8 code.  

Could you please move the utf-8 sequences in its own file, and load it
instead of having it inline?  

I don't think all compilers are to be utf-8 safe.  

   
>  Mi Jan 06 2010 02:01:48 EST von  "Brad Hards" <bradh at frogmouth.net> 
>Betreff: Re: [Freeassociation-devel] Problems with un-escaped characters in
>TZID
>
>  On Wednesday 23 December 2009 18:43:22 Brad Hards wrote:
>  
>>Hi,
>> 
>> I work with the OpenChange project (http://www.openchange.org), which
>> provides (amongst other things) a tool that does conversion from Exchange
>> calendars to ICalendar. We use libical for that.
>> 
>> One of our users reported that newlines in timezones (TZID) aren't
>>properly
>> escaped. Here is the original report:
>> http://trac.openchange.org/ticket/218
>> 
>> It does indeed appear to be a problem with libical. Attached is a small
>> patch for the libical regression tests that shows the problem. Here is the
>> output I see with the current (trunk, revision 982) libical.
>> 
>> ########## Test TZID escaping                       (43) ##########
>> DTSTART;VALUE=DATE;TZID=Timezone
>> with a newline:20090126
>> 
>> not ok 641 - test encoding of 'Timezone\nwith a newline'
>> # test failed: ""
>> #          at: regression.c:1270
>> #      got: DTSTART;VALUE=DATE;TZID=Timezone
>> with a newline:20090126
>> 
>> # expected: DTSTART;VALUE=DATE,TZID=Timezone\nwith a newline:20090126
>> 
>> 
>> I'm not very familiar with libical (just a user of the library), but it
>> looks like maybe icalparameter_as_ical_string_r() needs to handle the
>> CTLs?
>> 
>> Thoughts? Suggestions?
>>

>  Ping?
> 
> Brad
> 
>
>------------------------------------------------------------------------------
>
> This SF.Net email is sponsored by the Verizon Developer Community
> Take advantage of Verizon's best-in-class app development support
> A streamlined, 14 day to market process makes app distribution fast and
>easy
> Join now and get one step closer to millions of Verizon customers
> http://p.sf.net/sfu/verizon-dev2dev 
> _______________________________________________
> Freeassociation-devel mailing list
> Freeassociation-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freeassociation-devel
> 
>
>
>  

  

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/libical-devel/attachments/20100106/88360fbc/attachment.html>


More information about the libical-devel mailing list