[Freeassociation-devel] libical fixes for review (and commit if ok please)

[Gren Elliot]

On 05/08/2009 15:33, dothebart wrote:
>
> Hy Gren,
>
> Could you split your patch between style guide patches and functional 
> patches please?
>
> Which flags do you use? does --pedantic give these warnings?
>
> Do you have bug references to the functional patches you did like a 
> bugzilla link?
>

Hi,

I'll split up the patch into smaller bits as you suggest and send 
them.   Probably tomorrow as I need to head home soon.

To answer your other questions :

The compiler warning option we use is gcc's  "-Wstrict-prototypes".

We don't have specific Scalix Bugzilla reports for these issues.
The VTIMEZONE DTSTART issue doesn't apply to released Scalix products.  
The function call from our code which got a different return was :
      icaltimezone_get_builtin_timezone("Europe/Zurich");
With our previous version, this used to end up working off the .ics 
files directly.  We would prefer to use the newer code which can 
leverage OS updates to tzdata.

The EXDATE issue might apply to code out in the wild but we only spotted 
it in relation to new features under development.
The new code calculates FREEBUSY for a calendar and was mapping time off 
as BUSY for excluded instances in a recurrence - because the EXDATE was 
specified relative to a non-UTC timezone and hence always failed to 
match the instance time it was being compared against.

The compiler warnings just annoy our developers.

Regards,
Gren.