[Freeassociation-devel] [FA-commits] SF.net SVN: freeassociation:[844] trunk/libical/src

[Patrick Ohly]

Hi,

including Chenthill on the discussion. He's the author of the time zone
conversion code, I only wrote the test program. Sorry for top-posting,
but I wanted to preserve the discussion for him.

The broken offsets calculated with libical look random to me, but I
don't have a clue as to why. The original problem was that the *date* of
the offset switch wasn't calculated correctly, not the *offset*.

Did you also apply this patch:
http://svn.gnome.org/viewvc/libical?view=revision&revision=645

If you have, is it possible that some uninitialized memory is used
(either in the test program or libical)? Does valgrind say anything?

Bye, Patrick

On Mon, 2008-09-08 at 13:37 -0400, Allen Winter wrote:
> On Monday 08 September 2008 12:37:59 dothebart wrote:
> > >Mo Sep 08 2008 18:31:09 CEST von dothebart in 0000000000.Sent Items> an
> > >freeassociation-commits at lists.sourceforge.net 
> > >Betreff: [FA-commits] SF.net SVN: freeassociation:[844] trunk/libical/src
> > >
> > >Revision: 844
> > >
> > >http://freeassociation.svn.sourceforge.net/freeassociation/?rev=844&view=rev
> > >Author:   dothebart
> > >Date:     2008-09-08 16:31:06 +0000 (Mon, 08 Sep 2008)
> > >
> > >Log Message:
> > >-----------
> > >* chenthill/Patrick Ohly: Calculate the relative position of a week day
> > >properly.
> > >
> > >Modified Paths:
> > >--------------
> > > trunk/libical/src/libical/icaltz-util.c
> > > trunk/libical/src/test/Makefile.am
> > >
> > >Added Paths:
> > >-----------
> > > trunk/libical/src/test/timezones.c
> > >
> > >
> > >This was sent by the SourceForge.net collaborative development platform, the
> > >world's largest Open Source development site.
> > >
> > >-------------------------------------------------------------------------
> > >This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > >Build the coolest Linux based applications with Moblin SDK & win great
> > >prizes
> > >Grand prize is a trip for two to an Open Source event anywhere in the world
> > >http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > >_______________________________________________
> > >Freeassociation-commits mailing list
> > >Freeassociation-commits at lists.sourceforge.net
> > >https://lists.sourceforge.net/lists/listinfo/freeassociation-commits
> > >
> > >
> > 
> >   
> > 
> > Ok, applied the patch. Though I get this:  
> > 
> > ..  
> > 
> > America/Port_of_Spain: day 000: first failed: libc 2008-09-08 12:00:00 !=
> > libical 2008-09-08 11:53:56
> > America/St_Vincent: day 000: first failed: libc 2008-09-08 12:00:00 !=
> > libical 2008-09-08 11:55:04
> > America/Tortola: day 000: first failed: libc 2008-09-08 12:00:00 != libical
> > 2008-09-08 11:41:32
> > America/St_Thomas: day 000: first failed: libc 2008-09-08 12:00:00 != libical
> > 2008-09-08 11:40:16
> > Asia/Aden: day 000: first failed: libc 2008-09-08 12:00:00 != libical
> > 2008-09-08 12:00:48
> > Indian/Mayotte: day 000: first failed: libc 2008-09-08 12:00:00 != libical
> > 2008-09-08 12:00:56
> > Africa/Lusaka: day 000: first failed: libc 2008-09-08 12:00:00 != libical
> > 2008-09-08 11:53:08
> > Africa/Harare: day 000: first failed: libc 2008-09-08 12:00:00 != libical
> > 2008-09-08 12:04:12
> >  *** Summary: 400 zones tested, 21993 days failed, 124007 okay => 15% failed
> > ***  
> > 
> > while the original post in the bugzilla just had offses by hours, at least
> > here on my debian lenny we produce OFFSETS IN SECONDS AND MINUTES?  
> > 
> > Though, with the patch I get less troubles...  
> > 
> > Is anyone else able to reproduce this?  
> > 
> Yep, I got the exact same Summary message on my Fedora 9 system.
> 
> Patrick, any idea what's happening?
> 
> -Allen
-- 
Bye, Patrick Ohly
--  
Patrick.Ohly at gmx.de
http://www.estamos.de/