[Freeassociation-devel] Crash using Inline Attachments

[Allen Winter]

For years now we have been getting KOrganizer bug reports about crashes
when using inline attachments.

I'd like to finally fix that bug.  Investigating today I found that the crash is in libical.
icalattach_new_from_data() and icalattach_unref()

Before I post a patch, I need to know if anyone understands what the
free_fn_data argument to icalattach_new_from_data() is used for.

Actually, I'd like to eliminate the free_fn and free_fn_data arguments
because I don't see them being used for anything.

./src/libical/icalvalue.c:icalvalue_new_from_string_with_error() 
is the only place in all of libical that uses icalattach_new_from_data(),
but it passes 0 for both  free_fn and free_fn_data.

So can I remove those 2 args?
Other comments?

-Allen