[PATCH 0785/1285] Replace numeric parameter like 0444 with macro

Baole Ni baolex.ni at intel.com
Tue Aug 2 04:46:08 PDT 2016

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu at intel.com>
Signed-off-by: Baole Ni <baolex.ni at intel.com>
 drivers/net/wireless/marvell/libertas/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/libertas/main.c b/drivers/net/wireless/marvell/libertas/main.c
index 8541cbe..b4fa7bd 100644
--- a/drivers/net/wireless/marvell/libertas/main.c
+++ b/drivers/net/wireless/marvell/libertas/main.c
@@ -36,11 +36,11 @@ const char lbs_driver_version[] = "COMM-USB8388-" DRIVER_RELEASE_VERSION
 /* Module parameters */
 unsigned int lbs_debug;
-module_param_named(libertas_debug, lbs_debug, int, 0644);
+module_param_named(libertas_debug, lbs_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 unsigned int lbs_disablemesh;
-module_param_named(libertas_disablemesh, lbs_disablemesh, int, 0644);
+module_param_named(libertas_disablemesh, lbs_disablemesh, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

More information about the libertas-dev mailing list