[PATCH 50/75] libertas: declare MODULE_FIRMWARE

Dan Williams dcbw at redhat.com
Tue Nov 10 01:32:54 EST 2009


On Mon, 2009-11-09 at 09:07 +0100, Holger Schurig wrote:
> At Sat, 07 Nov 2009 22:00:03 +0000,
> Ben Hutchings wrote:
> > diff --git a/drivers/net/wireless/libertas/if_cs.c b/drivers/net/wireless/libertas/if_cs.c
> > index 9127d2a..9834e3f 100644
> > --- a/drivers/net/wireless/libertas/if_cs.c
> > +++ b/drivers/net/wireless/libertas/if_cs.c
> > @@ -48,6 +48,7 @@
> >  MODULE_AUTHOR("Holger Schurig <hs4233 at mail.mn-solutions.de>");
> >  MODULE_DESCRIPTION("Driver for Marvell 83xx compact flash WLAN cards");
> >  MODULE_LICENSE("GPL");
> > +MODULE_FIRMWARE("libertas_cs_helper.fw");
> 
> Do you intentionally only define specify the helper firmware? The
> device won't be working without loading "libertas_cs.fw" as well.
> 
> Do you have any pointer for me to what MDOULE_FIRMWARE does?  What
> user-space tool does it it for what purpose?

It's nice information to know from 'modinfo' or other uses so that we
might be able to find the firmware automatically.  Right now actually
PackageKit will figure out  missing firmware from udev when udev can't
find the right firmware, but having it in 'modinfo' is useful too.

Honestly I think we should actually reorganize the firmware and put it
in /lib/firmware/libertas or something.

Dan





More information about the libertas-dev mailing list