[PATCH] Marvell CF8381

Holger Schurig hs4233 at mail.mn-solutions.de
Mon Mar 23 08:13:10 EDT 2009

Hi Marek !


Some nitpicks:

1. you attached the patches, not inline
2. There's no signed-off
3. You didn't submit one mail per patch

All of this makes review harder. If you adhere a bit to
Documentation/SubmittingPatches you'd get the fame all by
yourself :-)

Some more rants:

--- a/drivers/net/wireless/libertas/if_cs.c
+++ b/drivers/net/wireless/libertas/if_cs.c
@@ -273,7 +273,14 @@ static int if_cs_poll_while_fw_download(struct if_cs_card *card, uint addr, u8 r
 #define IF_CS_PRODUCT_ID               0x0000001C
 #define IF_CS_CF8385_B1_REV            0x12
+#define        IF_CS_CF8381_B3_REV             0x04

Here's a tab, not a space. Maybe you run scripts/checkpatch.pl on it as well?

-       if (if_cs_read8(card, IF_CS_PRODUCT_ID) < IF_CS_CF8385_B1_REV) {
+       if (!(p_dev->manf_id == CF8381_MANFID &&
+               p_dev->card_id == CF8381_CARDID) &&
+               (if_cs_read8(card, IF_CS_PRODUCT_ID) < IF_CS_CF8385_B1_REV)) {

I think change then breaks the existing logic for 8385 cards.
code broke then the 8385 case. Therefore a NAK for now.

Kindly repost both patches again, with signed-off and fixes, thanks!

More information about the libertas-dev mailing list