[PATCH] libertas: name the network device wlan%d

Daniel Mack daniel at caiaq.de
Tue Aug 11 11:33:54 EDT 2009


On Tue, Aug 11, 2009 at 04:10:51PM +0100, Bob Dunlop wrote:
> On Tue, Aug 11 at 04:13, Daniel Mack wrote:
> > Devices created by the libertas driver are currently called eth%d. Which
> > is wrong, because the device does not at all have anything to do with
> > Ethernet. And it is also confusing when used on devices with more than
> > one network device.
> > 
> > Fix this by calling it wlan%d.
> 
> Just a nit pick but shouldn't the patch also include:
> 
> @@ -1176,7 +1176,7 @@
>  	/* Allocate an Ethernet device and register it */
>  	dev = alloc_etherdev(sizeof(struct lbs_private));
>  	if (!dev) {
> -		lbs_pr_err("init ethX device failed\n");
> +		lbs_pr_err("init wlanX device failed\n");
>  		goto done;
>  	}
>  	priv = netdev_priv(dev);
> 
> 
> So collars and cuffs match.

Oh, of course.

Thanks,
Daniel



More information about the libertas-dev mailing list