[PATCH] libertas: if_spi: call board specific teardown method if probe fails

Dan Williams dcbw at redhat.com
Fri Apr 17 09:45:38 EDT 2009

On Fri, 2009-04-17 at 09:33 -0400, Dan Williams wrote:
> On Wed, 2009-03-11 at 16:33 +0100, Uli Luckas wrote:
> > if_spi: call board specific teardown method if probe fails
> > 
> > Signed-off-by: Uli Luckas <u.luckas at road.de>
> Hmm; I see now you only sent to libertas-dev...
> (not that this is specified anywhere, but it's supposed to be general
> Linux wireless development knowledge so I guess here it is) 
> Patches for the actual Linux kernel for any wireless driver should be
> sent to linux-wireless at vger.kernel.org, which is where the Linux
> wireless subsystem maintainer (John Linville) takes submissions from.
> libertas-dev is more about specific problems with the Marvel fullmac
> libertas devices, so that we aren't drowned out in the large traffic on
> linux-wireless.  We used to maintain our own git tree until the libertas
> driver was fully merged into the kernel.
> http://linuxwireless.org/en/developers/Documentation
> So you'll want to CC your patch to linux-wireless, where it will get
> reviewed and if no issues are found (I looked at it when you sent it,
> and it looks fine, but I had assumed wrongly that it was also sent to
> linux-wireless) I'll ack it and John will pick it up for inclusion in
> the kernel.

Also, you'll want to put your patch *inline* at the bottom of the mail
message, because that's the easiest way for developers to read the mail.
Attachments require a lot more manual effort, and when people have
literally ten, twenty, thirty or more patches to look at a day, they get
grumpy about having to open the attachment in a different program or
whatever.  I don't personally care, but the people that actually apply
your patch will.  Make sure your mailer doesn't reformat the patch too,
but pasting it into the mail using the "preformatted" option or whatever
your mailer requires.


More information about the libertas-dev mailing list