[PATCH] libertas: before sleeping, check for a command result

[Johan Adolfsson]

----- Original Message ----- 
From: "Holger Schurig" <hs4233 at mail.mn-solutions.de>
To: "Johan Adolfsson" <johana at axis.com>
Cc: <libertas-dev at lists.infradead.org>; "'Dan Williams'" <dcbw at redhat.com>; 
<linux-wireless at vger.kernel.org>; "'John W. Linville'" 
<linville at tuxdriver.com>
Sent: Friday, May 23, 2008 4:57 PM
Subject: Re: [PATCH] libertas: before sleeping, check for a command result


>> I have experience a couple of timeout and resends and after
>> sending another commands I get the response from the previous
>> one, and the patch seems to solve a couple of those for me -
>> still se some problem fetching packet from  firmware with ret
>> = -22 though. And it could be dependant on how much debug I
>> have turned on..
>
> Keep in mind that maybe the firmware actually really takes ages
> to complete a command. David Woodhouse reported this.
>
> In my case, because I had the proper debugging statements in my
> interrupt handler, I knew for sure that I already received the
> response. Can you verify that, for the comment timeouts you
> noticed, if this did happen or not?

While trying to find out what went wrong I believe I stumbled
on a cache issue since our sdio driver didn't invalidate the cache
and the DMA is not cachecoherent.

Possible something for others to check in their SDIO drivers
as well.
Ran into some weird problems when trying to verify if it solved my problem 
though, so I will get back with more info when I get it up and running 
again.

Best regards
/Johan