[PATH] libertas: speeds up downloading of CF firmware

Andreas Schwab schwab at suse.de
Fri May 23 07:20:15 EDT 2008


Holger Schurig <hs4233 at mail.mn-solutions.de> writes:

> Keep the timeout the same (1000*500 == 100000 * 5), but take shorter
> naps. Makes downloading the firmware slightly faster.
>
> Signed-off-by: Holger Schurig <hs4233 at mail.mn-solutions.de>
>
> --- linux.orig/drivers/net/wireless/libertas/if_cs.c
> +++ linux/drivers/net/wireless/libertas/if_cs.c
> @@ -148,11 +148,11 @@
>  {
>  	int i;
>  
> -	for (i = 0; i < 1000; i++) {
> +	for (i = 0; i < 100000; i++) {
>  		u8 val = if_cs_read8(card, addr);
>  		if (val == reg)
>  			return i;

That changes the return value.  Although it doesn't matter since all
callers only check for < 0, it should perhaps be changed to return 0
here to avoid confusion.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab at suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



More information about the libertas-dev mailing list