[PATCH 1/2] Extend MESH_CONFIG command to access non-volatile configuration.

[David Woodhouse]

On Sat, 2008-05-17 at 00:55 -0700, Javier Cardona wrote:
> This patch is based on a patch from Shailendra Govardhan and Brian Cavagnolo.
> It extends the MESH_CONFIG command to configure non-volatile parameters on
> libertas devices that support them (e.g. OLPC Active Antenna).
> 
> This patch only implements the driver/firmware interface.
> 
> See http://dev.laptop.org/ticket/6823 for minimal testing results and known
> issues.

Thanks. That looks much better, modulo a few cosmetic things which I'll
fix up, and this (which I'll also fix):

+               cmd.length = sizeof(struct mrvl_meshie_val);

Sparse would have told you about that, if you built with
'C=2 CF=-D__CHECK_ENDIAN__':

drivers/net/wireless/libertas/cmd.c:1052:14: warning: incorrect type in assignment (different base types)
drivers/net/wireless/libertas/cmd.c:1052:14:    expected restricted unsigned short [addressable] [assigned] [usertype] length
drivers/net/wireless/libertas/cmd.c:1052:14:    got unsigned int 

I'd recommend always testing on a big-endian box, too. Sparse is good,
but no substitute for the real thing.

-- 
dwmw2