[PATCH stable] Separate multicast configuration for mesh and wlan interfaces.

Andrew Morton akpm at linux-foundation.org
Tue May 13 15:30:53 EDT 2008


On Tue, 13 May 2008 13:20:19 -0400
Andres Salomon <dilinger at queued.net> wrote:

> On Tue, 13 May 2008 15:45:39 +0100
> David Woodhouse <dwmw2 at infradead.org> wrote:
> 
> > On Tue, 2008-05-13 at 15:38 +0100, David Woodhouse wrote:
> > > 
> > > And even without that, it doesn't seem to do the right thing. Set
> > > IFF_PROMISC mode on one interface, then on the other, then clear it
> > > on the first.... it should remain set in hardware. And AFAICT it
> > > doesn't.
> > > 
> > > I'll see if I can make it work....
> > 
> > Hm, a single cup of tea mostly achieves that; sorry :)
> > 
> > I was missing the fact that priv->packetfilter[] is now an array.
> > It got a bit clearer after I reformatted it to stop trying to fit in
> > 80 columns. Sometimes the code just doesn't fit; it's painful to try
> > to make it.
> > 
> 
> Gosh, I sure wish you, Andrew, checkpatch.pl, and Ingo[0] were all on the same page
> regarding that.. it would sure make my life easier.
> 

David is off in his own little world on this and can be safely ignored.

Meanwhile the rest of us are forced to stare at crocks of shit like
http://userweb.kernel.org/~akpm/x.jpg, wondering who hates us and why.




More information about the libertas-dev mailing list