state of CF suspend / resume

[David Woodhouse]

On Tue, 2008-04-29 at 15:54 +0200, Holger Schurig wrote:
> I'd like to implement suspend/resume for the compact flash 
> driver. From what I know so far, suspend/resume is intermingled 
> with Wake-on-LAN. lbs_suspend() in main.c contains this code 
> fragment:
> 
>         if (priv->wol_criteria == 0xffffffff) {
>                 lbs_pr_info("Suspend attempt without configuring"
>                             "wake params!\n");
>                 return -EINVAL;
>         }
> 
> I don't know why, it should be perfectly legal to do suspend 
> without Wake-on-LAN. Or shouldn't it?

It's checking for 0xffffffff (i.e. never set), not checking for zero.

You can do suspend without Wake-on-LAN, but you still have to send the
HOST_SLEEP_CFG command first. Otherwise, the firmware misbehaves -- iirc
it never comes back from sleep.

-- 
dwmw2