[PATCH] libertas: reduce command retry time

David Woodhouse dwmw2 at redhat.com
Wed Apr 30 16:43:16 EDT 2008

On Wed, 2008-04-30 at 16:34 -0400, Dan Williams wrote:
> On Wed, 2008-04-30 at 16:44 +0200, Holger Schurig wrote:
> > In the normal case, an unsuccessful command would be tried for
> > 10*5 seconds, or 10*10 seconds in the worst case. This patch
> > reduces this to 3*1 seconds, or 3*5 seconds in the worst case.
> > 
> > Also changed the needless del_timer_sync(&priv->command_timer);
> > to del_timer().
> > 
> > Signed-off-by: Holger Schurig <hs4233 at mail.mn-solutions.de>
> Sounds fine to me...  Woodhouse?

I think I've seen it take a few of the 5-second timeouts. The firmware
on this thing really is a steaming pile of shit. I wouldn't like to
decrease the maximum so drastically.

Also, that del_timer_sync() happens in the module unload path, doesn't
it? I'd want to see why you think it isn't needed.


More information about the libertas-dev mailing list