[PATCH] libertas: Fix ethtool statistics

Sebastian Siewior liber+tas at ml.breakpoint.cc
Sun Apr 20 15:10:51 EDT 2008

* David Woodhouse | 2008-04-20 11:56:32 [+0100]:

>On Sun, 2008-04-20 at 10:41 +0200, Sebastian Siewior wrote:
>> The function before lbs_ethtool_get_stats() (in net code that
>> determinate the number of elements, dunno the name right now) is able to
>> return an error. This one could check if the firmware has mesh support.
>That's what my second patch does.
got to check that patch.

>> Do I understand this correct: If the firmware has support for mesh
>> devices than we have ethX and mshX and only mshX should return the
>> statistics?
>Well, they are _mesh_ statistics :)
yes, but I have two interfaces or just one?

>Yeah, that might be worthwhile.
>> I will try to form a patch around Monday that fixes Dan's comments (if
>> nobody else is going to).
>Which comments? If we apply your original patch, followed by my patch in
><1208509888.9212.291.camel at pmac.infradead.org> (which for some reason
>only went to wireless-dev, not libertas-dev), then I think it's fine.
The comments were
- everything what deals with mesh should take the mash lock
- check for mesh support before calling lbs_ethtool_get_stats()

If your second patch deals with these than yes it should be fine.



More information about the libertas-dev mailing list