[PATCH] libertas: Fix ethtool statistics

Holger Schurig hs4233 at mail.mn-solutions.de
Fri Apr 18 04:10:57 EDT 2008


When I apply this patch and do "ethtool -S eth1", I get this:

$ ethtool -S eth1
NIC statistics:
     drop_duplicate_bcast: 7
     drop_ttl_zero: 0
     drop_no_fwd_route: 0
     drop_no_buffers: 9223372036854775808
     fwded_unicast_cnt: 0
     fwded_bcast_cnt: 0
     drop_blind_table: 0
     tx_failed_cnt: 9223372036854775808

But more severely, I get this in dmesg:

libertas enter: lbs_ethtool_get_stats()
libertas: PREP_CMD: command 0x009b failed: 2
My firmware simply doesn't support the 009b command. It seems 
also wrong to call an MESH related command on an struct 
net_device *dev which is not priv->mesh_dev.

That ethtool returns junk like "9223372036854775808" is another 
error. lbs_mesh_access() returned 2, and the code does "if (ret) 
return ret". Maybe it should be like "if (ret) return -ENOSYS 
(or some other ENOxxx) instead?

More information about the libertas-dev mailing list