[PATCH] libertas: fix SSID output

Dan Williams dcbw at redhat.com
Sun Feb 25 08:37:28 EST 2007


On Sat, 2007-02-24 at 16:58 +0100, Holger Schurig wrote:
> * a newline was missing
> * changed %32s to '%s', no need to right justify the ESSID

Hmm; would be nice to actually print this out as hex, not a string,
since an SSID is just an array of 32 bytes with no restrictions.  You
can even have SSIDs with all zeros, which is perfectly valid and is how
Cisco used to implement SSID-hiding.  But anyway, this patch doesn't
regress so it's not a problem.

Dan

> Signed-off-by: Holger Schurig <hs4233 at mail.mn-solutions.de>
> ---
>  drivers/net/wireless/libertas/scan.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/libertas/scan.c b/drivers/net/wireless/libertas/scan.c
> index c860e03..6db967f 100644
> --- a/drivers/net/wireless/libertas/scan.c
> +++ b/drivers/net/wireless/libertas/scan.c
> @@ -1076,7 +1076,7 @@ static int InterpretBSSDescriptionWithIE(struct bss_descriptor * pBSSEntry,
>  			pBSSEntry->ssid.ssidlength = elemlen;
>  			memcpy(pBSSEntry->ssid.ssid, (pcurrentptr + 2),
>  			       elemlen);
> -			lbs_deb_scan("ssid: %32s", pBSSEntry->ssid.ssid);
> +			lbs_deb_scan("ssid '%s'\n", pBSSEntry->ssid.ssid);
>  			break;
>  
>  		case SUPPORTED_RATES:
> @@ -1599,7 +1599,7 @@ int libertas_get_scan(struct net_device *dev, struct iw_request_info *info,
>  	}
>  
>  	if (adapter->connect_status == libertas_connected)
> -		lbs_deb_scan("Current ssid: %32s\n",
> +		lbs_deb_scan("current ssid '%s'\n",
>  		       adapter->curbssparams.ssid.ssid);
>  
>  	lbs_deb_scan("Scan: Get: numinscantable = %d\n",
> @@ -1620,7 +1620,7 @@ int libertas_get_scan(struct net_device *dev, struct iw_request_info *info,
>  
>  		pscantable = &adapter->scantable[i];
>  
> -		lbs_deb_scan("i=%d  ssid: %32s\n", i, pscantable->ssid.ssid);
> +		lbs_deb_scan("i %d, ssid '%s'\n", i, pscantable->ssid.ssid);
>  
>  		cfp =
>  		    libertas_find_cfp_by_band_and_channel(adapter, 0,




More information about the libertas-dev mailing list