[LEDE-DEV] [PATCH] lantiq: dsl_notify: also restart pppoe interfaces

Felix Fietkau nbd at nbd.name
Mon May 8 23:47:48 PDT 2017


On 2017-05-09 08:46, Mathias Kresin wrote:
> 09.05.2017 00:44, Valentin Spreckels:
>> Signed-off-by: Valentin Spreckels <Valentin.Spreckels at Informatik.Uni-Oldenburg.DE>
>> ---
> 
> Thanks a lot for your patch. Would you please add a commit message which 
> describes the issue you are trying to fix. At the moment I fail to see 
> why this change is required.
> 
> I rather suspect that the whole pppoa interface handling can be removed 
> from dsl_notify.sh. Isn't it handled by netifd now days?
pppoa needs special treatment, because it connects to ATM directly
without going through a netdev.

For pppoe, this makes no sense, so this patch should be unnecessary.

- Felix



More information about the Lede-dev mailing list