[LEDE-DEV] [PATCH] Adding acct_interval to wireless configuration

[Yury Shvedov]

Like that?

Make an ability to configure Accounting-Interim-Interval via UCI

Signed-off-by: Yury Shvedov <yshvedov at wimarksystems.com>
---
  package/network/services/hostapd/files/hostapd.sh | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/package/network/services/hostapd/files/hostapd.sh 
b/package/network/services/hostapd/files/hostapd.sh
index 86e9a32e5b..2b8023c228 100644
--- a/package/network/services/hostapd/files/hostapd.sh
+++ b/package/network/services/hostapd/files/hostapd.sh
@@ -151,6 +151,7 @@ hostapd_common_add_bss_config() {
      config_add_string acct_server
      config_add_string acct_secret
      config_add_int acct_port
+    config_add_int acct_interval
       config_add_string dae_client
      config_add_string dae_secret
@@ -207,8 +208,8 @@ hostapd_set_bss_options() {
          wps_pushbutton wps_label ext_registrar wps_pbc_in_m1 
wps_ap_setup_locked \
          wps_independent wps_device_type wps_device_name 
wps_manufacturer wps_pin \
          macfilter ssid wmm uapsd hidden short_preamble rsn_preauth \
-        iapp_interface eapol_version acct_server acct_secret acct_port \
-        dynamic_vlan ieee80211w
+        iapp_interface eapol_version dynamic_vlan ieee80211w \
+        acct_server acct_secret acct_port acct_interval \
       set_default isolate 0
      set_default maxassoc 0
@@ -249,6 +250,8 @@ hostapd_set_bss_options() {
          append bss_conf "acct_server_port=$acct_port" "$N"
          [ -n "$acct_secret" ] && \
              append bss_conf "acct_server_shared_secret=$acct_secret" "$N"
+        [ -n "$acct_interval" ] && \
+            append bss_conf 
"radius_acct_interim_interval=$acct_interval" "$N"
      }
       local vlan_possible=""
-- 
2.13.1


On 06/27/2017 07:22 AM, Stijn Tintel wrote:
> On 29-05-17 14:04, Yury Shvedov wrote:
>> Hi, I'm new here and I wonder why there is still no UCI option to configure Radius-Accounting-Interim-Interval.
>> I've made a patch to fix that and like to share it to others and ask is there any serious reason for lack of such
>> option?
>>
>> Make an ability to configure Accounting-Interim-Interval via UCI
> The patch is broken. Please use git send-email or create a PR on Github.
>
>> Signed-off-by: Yury Shvedov <yshvedov at wimarksystems.com>
>> ---
>>   package/network/services/hostapd/files/hostapd.sh | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/network/services/hostapd/files/hostapd.sh b/package/network/services/hostapd/files/hostapd.sh
>> index 6fb902e376..e6bccef39b 100644
>> --- a/package/network/services/hostapd/files/hostapd.sh
>> +++ b/package/network/services/hostapd/files/hostapd.sh
>> @@ -151,6 +151,7 @@ hostapd_common_add_bss_config() {
>>   	config_add_string acct_server
>>   	config_add_string acct_secret
>>   	config_add_int acct_port
>> +	config_add_int acct_interval
>>    	config_add_string dae_client
>>   	config_add_string dae_secret
>> @@ -208,7 +209,7 @@ hostapd_set_bss_options() {
>>   		wps_independent wps_device_type wps_device_name wps_manufacturer wps_pin \
>>   		macfilter ssid wmm uapsd hidden short_preamble rsn_preauth \
>>   		iapp_interface eapol_version acct_server acct_secret acct_port \
>> -		dynamic_vlan ieee80211w
>> +		acct_interval dynamic_vlan ieee80211w
> Please group the 4 acct_* directives on the same line, and combine the
> resulting 2 short lines.
>>    	set_default isolate 0
>>   	set_default maxassoc 0
>> @@ -249,6 +250,8 @@ hostapd_set_bss_options() {
>>   		append bss_conf "acct_server_port=$acct_port" "$N"
>>   		[ -n "$acct_secret" ] && \
>>   			append bss_conf "acct_server_shared_secret=$acct_secret" "$N"
>> +		[ -n "$acct_interval" ] && \
>> +			append bss_conf "radius_acct_interim_interval=$acct_interval" "$N"
>>   	}
>>    	local vlan_possible=""
> Thanks,
> Stijn

-- 
Kind Regards
Yury Shvedov
WiMark Systems