[LEDE-DEV] procd: cherry-pick fixes into lede-17.01 branch

[Florian Fainelli]

On 06/20/2017 07:52 AM, Daniel Golle wrote:
> Hi!
> 
> I've created a lede-17.01 branch for procd so fixes can be
> cherry-picked from master onto that branch.

I suppose that works, but I would be a bit concerned that we may have to
do the same thing with other "sub" projects that are maintained (netifd,
ubox etc.) and that maybe just putting the different patches under
package/*/*/patches may be equally easy to manage.

> 
> I suggest to pick the commits listed below:
> 453116e system: introduce new attribute board_name
> e5b963a preinit: define _GNU_SOURCE
> e5ff8ca upgraded: cmake: Find and include uloop.h
> f367ec6 hotplug: fix a memory leak in handle_button_complete()
> 796ba3b service/service_stopped(): fix a use-after-free
> 79bbe6d system: return legacy board name
> e7bb2c8 upgraded: define __GNU_SOURCE
> 992b796 rcS: add missing fcntl.h include
> d42b21e procd/rcS: Use /dev/null as stdin
> 1247db1 procd: Log initscript output prefixed with script name
> 8d720b2 procd: Don't use syslog before its initialization
> 2555474 procd: Add missing \n in debug message
> 8f218f5 procd: service gets deleted when its last instance is freed

Works for me, thanks!

> 
> I would **not** pick:
> 63789e5 init: add support for sysupgrades triggered from preinit
> 5b1fb35 Remove code that has become unnecessary after sysupgrade changes
> 5918b6d upgraded: add support for passing a "command" argument to stage2
> 056d8dd upgraded: link dynamically, chroot during exec
> 7c6cf55 system: always support staged sysupgrade
> e0098d4 service/instance: add an auto start option
> abedd7f procd: update modprobe path
> 
> 
> Unless someone objects within 1 week from now, I take it as a passive
> consensus and will update the lede-17.01 branch as well as the procd
> package Makefile on the lede-17.01 branch.
> 
> 
> Cheers
> 
> 
> Daniel
> 


-- 
Florian