[LEDE-DEV] [PATCH v2 1/2] base-files: allocate uid/gid starting from 65536

Yousong Zhou yszhou4tech at gmail.com
Fri Jun 16 06:55:54 PDT 2017


On 16 June 2017 at 20:15, Karl Palsson <karlp at tweak.net.au> wrote:
>
> Daniel Golle <daniel at makrotopia.org> wrote:
>> On Fri, Jun 16, 2017 at 10:30:14AM -0000, Karl Palsson wrote:
>> >
>> >
>> > I fairly strong feel that this change brings no value to the
>> > table.
>>
>> I disagree. For now, the two allocation schemes (hardcoded vs.
>> dynamic) are competing for the same address space. This can
>> result in a hard-coded UID/GID to be already allocated to a
>> package using the dynamic allocation method. Shifting the
>> dynamic allocation to the range starting from 65536 solves that
>> problem in a convenient way. Hence I support Yousong's change.
>>
>
> This doesn't fix that. There's absolutely nothing here that stops
> someone using a hardcoded uid/gid of 65536 or so either. This
> just changes one magic number to be a different magic number. =>
> no gain.

The check on 65536 will be enforced by the metadata.pm change in the
2nd patch.  It will ensure that no future release of LEDE will allow
packages taking static uid/gid >= 65536.

                yousong



More information about the Lede-dev mailing list