[LEDE-DEV] [PATCH 1/2] fstools: Replace strerror(errno) with %m format.

Felix Fietkau nbd at nbd.name
Sun Dec 10 11:51:07 PST 2017


On 2017-12-10 13:54, Arjen de Korte wrote:
> Citeren Rosen Penev <rosenp at gmail.com>:
> 
>> Saves 1472 bytes under glibc. No other difference.
> 
> Except that this is GNU C only. I'm not sure if this is worth breaking  
> portability. It would probably be better to put these changes in  
> appropriate #ifdef/#else/#endif to only use this if GNU C is used.
fstools is already inherently Linux specific, and all the major Linux
libcs (glibc, musl, uClibc) support this feature.
I don't think it makes any sense to add #ifdef hackery here.

- Felix



More information about the Lede-dev mailing list