[LEDE-DEV] [PATCH 5/5] ar71xx: add support for D-Link DAP-2695 rev. A1

[Mathias Kresin]

11.09.2016 18:12, Stijn Tintel:
> diff --git a/target/linux/ar71xx/base-files/etc/board.d/02_network b/target/linux/ar71xx/base-files/etc/board.d/02_network
> index b637113..65292b0 100755
> --- a/target/linux/ar71xx/base-files/etc/board.d/02_network
> +++ b/target/linux/ar71xx/base-files/etc/board.d/02_network
> @@ -538,6 +538,11 @@ wndr3700)
>  	ucidef_add_switch_port_attr "switch0" 5 led 2
>  	;;
>
> +dap-2695-a1)
> +	ucidef_set_interfaces_lan_wan "eth0" "eth1"
> +	ucidef_add_switch "switch0" "0 at eth0" "2:lan" "3:wan" "6 at eth1"

First of all, I've no hands on experience with switches having two cpu 
ports. It might be the reason for what you are doing here.

The ucidef_set_interfaces_lan_wan seams superfluous to me. 
ucidef_add_switch calls _ucidef_finish_switch_roles[0] which in the end 
overwrites the lan and wan interface set by 
ucidef_set_interfaces_lan_wan using _ucidef_set_interface[1].

Mathias

[0] 
https://git.lede-project.org/?p=source.git;a=blob;f=package/base-files/files/lib/functions/uci-defaults.sh;hb=d14c28fc80d98cc712074c869cbd1659398e8829#l235
[1] 
https://git.lede-project.org/?p=source.git;a=blob;f=package/base-files/files/lib/functions/uci-defaults.sh;hb=d14c28fc80d98cc712074c869cbd1659398e8829#l188