[LEDE-DEV] [PATCH] kernel: clean up usb gadget support

[Felix Fietkau]

On 2016-09-06 18:57, Tim Harvey wrote:
> On Sat, Sep 3, 2016 at 5:00 AM, Felix Fietkau <nbd at nbd.name> wrote:
>> Adding libcomposite.ko to multiple packages is a really bad idea.
>> Why did you prefer that over having proper dependencies in place?
> 
> I don't believe I added any deps - I removed libcomposite from the
> menu selection and included it directly in the gadgets that require it
> because as far as I know there is no point in having libcomposite.ko
> without the g_* drivers that use it.
Adding libcomposite.ko to multiple packages is exactly the problem.
That way you make it impossible to cleanly install multiple gadget
modules. And besides, duplicating the same files in multiple packages is
rather ugly.

> On a related note, what do you think about replacing all gadget
> drivers (g_*) with usb_f_* modules using CONFIG_USB_CONFIG_FS allowing
> userspace configuration of gadgets? I can see an OpenWrt init script
> that builds composite gadgets based off of UCI config options. I'm not
> sure what the future holds for the various g_* modules as you can
> re-create those easily in userspace now.
Makes sense to me, but I don't know much about this stuff.

- Felix