[LEDE-DEV] [OpenWrt-Devel] [PATCH netifd 2/3] interface: Only teardown interfaces having no proto task when l3_dev link lost

[Hans Dedecker]

On Thu, Jul 14, 2016 at 11:20 PM, Felix Fietkau <nbd at nbd.name> wrote:
> On 2016-07-14 23:10, Hans Dedecker wrote:
>> Felix,
>>
>> Currently the xl2tp protocol script registers itself as having
>> no_proto_task which is used in proto_shell_task_finish to send a
>> teardown when the shell is in setup state an having a proto task.
>> I re-used the no_proto_task flag to send a teardown in case l3 dev
>> link loss is detected.
>> Do I understand it correctly you favour adding an explicit flag (to be
>> set by the protocol script in this case l2tp) and thus decouple the
>> teardown from the no_proto_task flag ?
> Yes, that's exactly what I meant. What's your opinion on that?
Agree with the idea as currently the no_proto_task flag is overloaded;
additionally it will allow the protocol handlers to register for a
teardown on l3 dev link loss decoupled from the no_proto task flag. I
will cook a patch after my holidays

Hans
>
> - Felix