[PATCH 4/6] riscv: Enable gen_report() to print the wrong value in case of test failure

cem at kernel.org cem at kernel.org
Thu Feb 29 04:42:10 PST 2024


From: Carlos Maiolino <cem at kernel.org>

If the test fails because the expected value doesn't match, it's useful to know
what value was actually printed.

Signed-off-by: Carlos Maiolino <cmaiolino at redhat.com>
---
 riscv/sbi.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/riscv/sbi.c b/riscv/sbi.c
index fa28d7c8..8ad8f375 100644
--- a/riscv/sbi.c
+++ b/riscv/sbi.c
@@ -28,7 +28,12 @@ static bool env_is_defined(const char *env)
 static void gen_report(struct sbiret *ret, long expected)
 {
 	report(!ret->error, "no sbi.error");
-	report(ret->value == expected, "expected sbi.value");
+
+	if (ret->value == expected)
+		report(true, "expected sbi.value");
+	else
+		report(false, "expected sbi.value: %ld - Got: %ld",
+		       expected, ret->value);
 }
 
 static void check_base(void)
-- 
2.43.2




More information about the kvm-riscv mailing list