[PATCH RFC][makedumpfile 01/10] dwarf_info: Support kernel address randomization

[Tao Liu]

Hi Kazu,

Thanks for your review of the patch [1 & 2].

As for the left [3 - 10] patches, I will redraft and post v2 later.

Thanks,
Tao Liu

On Mon, Sep 29, 2025 at 7:30 PM HAGIO KAZUHITO(萩尾　一仁)
<k-hagio-ab at nec.com> wrote:
>
> Hi Tao,
>
> On 2025/06/10 18:57, Tao Liu wrote:
> > There is a bug of not supporting randomized kernel address, this patch fix it.
> >
> > Signed-off-by: Tao Liu <ltao at redhat.com>
>
> apologies for my long delay and thank you for the patch.
>
> This patch looks good to me and I would like to merge this separately
> from the series, so
>
> Acked-by: Kazuhito Hagio <k-hagio-ab at nec.com>
>
> Thanks,
> Kazu
>
> > ---
> >   erase_info.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/erase_info.c b/erase_info.c
> > index af6bfae..b67d1d0 100644
> > --- a/erase_info.c
> > +++ b/erase_info.c
> > @@ -1881,7 +1881,7 @@ get_symbol_addr_all(char *name) {
> >       if (!strcmp(get_dwarf_module_name(), "vmlinux")) {
> >               symbol_addr = get_symbol_addr(name);
> >               if (symbol_addr)
> > -                     return symbol_addr;
> > +                     return symbol_addr + info->kaslr_offset;
> >
> >               vmlinux_searched = 1;
> >       }
> > @@ -1942,9 +1942,9 @@ get_symbol_addr_all(char *name) {
> >        * this function is called with debuginfo set to a particular
> >        * kernel module and we are looking for symbol in vmlinux
> >        */
> > -     if (!vmlinux_searched)
> > -             return get_symbol_addr(name);
> > -     else
> > +     if (!vmlinux_searched && !!(symbol_addr = get_symbol_addr(name))) {
> > +             return symbol_addr + info->kaslr_offset;
> > +     } else
> >               return NOT_FOUND_SYMBOL;
> >   }
> >