[MAKEDUMPFILE PATCH 1/2] Add option to prevent writing the dumpfile

HAGIO KAZUHITO(萩尾 一仁) k-hagio-ab at nec.com
Thu Jan 28 04:00:41 EST 2021


-----Original Message-----
> Hi Julien,
> 
> Thanks for the patches, and sorry for the late reply..
> 
> -----Original Message-----
> > Add a --dry-run option to run all operations without writing the
> > dump to the output file.
> 
> First, I think makedumpfile should not change its behavior (path checks,
> messages emitted, etc.) and exit code except for writing the dumpfile
> with or without the --dry-run option.  For example with this patch:
> 
>   $ touch dumpfile
>   $ makedumpfile -d 1 vmcore dumpfile --dry-run  --> ok, no problem
>   $ makedumpfile -d 1 vmcore dumpfile            --> error
> 
> This change is a bit strange to me.  So with this premise, commented inline
> and attached a modified patch at end of this email.  Could you check those?

This patchset is applied with some modifications:
https://github.com/makedumpfile/makedumpfile/compare/54aec38...6f3e75a

I will add another for counting bytes to be written and more readable stats later..

Thanks,
Kazu




More information about the kexec mailing list