[PATCH] kexec-tools: Fix a prompt message when crashkernel is not reserved

Bhupesh SHARMA bhupesh.linux at gmail.com
Wed Sep 16 14:44:02 EDT 2020


Hi Youling,

On Sat, Sep 12, 2020 at 7:10 AM Youling Tang <tangyouling at loongson.cn> wrote:
>
> Where Y specifies how much memory to reserve for the dump-capture kernel
> and X specifies the beginning of this reserved memory. So Y should be
> placed before X.
>
> Signed-off-by: Youling Tang <tangyouling at loongson.cn>
> ---
>  kexec/kexec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kexec/kexec.c b/kexec/kexec.c
> index bb88caa..fd7c8d2 100644
> --- a/kexec/kexec.c
> +++ b/kexec/kexec.c
> @@ -1530,7 +1530,7 @@ int main(int argc, char *argv[])
>             !is_crashkernel_mem_reserved()) {
>                 die("Memory for crashkernel is not reserved\n"
>                     "Please reserve memory by passing"
> -                   "\"crashkernel=X at Y\" parameter to kernel\n"
> +                   "\"crashkernel=Y at X\" parameter to kernel\n"
>                     "Then try to loading kdump kernel\n");
>         }
>
> --
> 2.1.0

Thanks for the patch. LGTM, so:
Reviewed-by: Bhupesh Sharma <bhsharma at redhat.com>

- Bhupesh



More information about the kexec mailing list