[PATCH v2 kexec-tools] arm: do not build iomem.o target with no soruce

Pratyush Anand panand at redhat.com
Fri Dec 9 04:15:55 PST 2016



On Friday 09 December 2016 04:30 PM, Simon Horman wrote:
> Header files should be added to the distribution but not
> used to derive targets for compilation. In this an attempt was
> made to build iomem.o, but iomem.c does not exist so this fails.
>
> Fixes: 1574ff1aae4f ("arm: include phys_to_virt.h and iomem.h in distribution")
> Cc: Dave Young <dyoung at redhat.com>
> Cc: Pratyush Anand <panand at redhat.com>
> Signed-off-by: Simon Horman <horms at verge.net.au>
> ---
> v2
> * add headers directly to dist
> ---
>  kexec/arch/arm/Makefile | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/kexec/arch/arm/Makefile b/kexec/arch/arm/Makefile
> index 871979e0ae26..4454f47a48df 100644
> --- a/kexec/arch/arm/Makefile
> +++ b/kexec/arch/arm/Makefile
> @@ -27,9 +27,8 @@ arm_KEXEC_SRCS += $(libfdt_SRCS)
>
>  arm_UIMAGE = kexec/kexec-uImage.c
>  arm_PHYS_TO_VIRT = kexec/arch/arm/phys_to_virt.c
> -arm_PHYS_TO_VIRT += kexec/arch/arm/iomem.h
> -arm_PHYS_TO_VIRT += kexec/arch/arm/phys_to_virt.h
>
>  dist += kexec/arch/arm/Makefile $(arm_KEXEC_SRCS) $(arm_PHYS_TO_VIRT)	\
> -	kexec/arch/arm/crashdump-arm.h kexec/arch/arm/kexec-arm.h	\
> +	kexec/arch/arm/iomem.h kexec/arch/arm/phys_to_virt.h \
> +	kexec/arch/arm/crashdump-arm.h kexec/arch/arm/kexec-arm.h \
>  	kexec/arch/arm/include/arch/options.h
>

Reviewed-by: Pratyush Anand <panand at redhat.com>



More information about the kexec mailing list