[PATCH] vmcore-dmesg: don't enforce largefile handling

Yegor Yefremov yegorslists at googlemail.com
Wed Jun 11 06:02:51 PDT 2014


On Wed, Jun 11, 2014 at 1:45 AM, Simon Horman <horms at verge.net.au> wrote:
> On Tue, Jun 10, 2014 at 09:29:29PM +0200, Yegor Yefremov wrote:
>> Breaks build on !largefile toolchains.
>>
>> Instead simply use whatever mode is selected by toolchain / CFLAGS.
>
> Perhaps the use of configure or something similar is in order
> to select these options if they are available. It seems
> to me that one would want them if one can have them.

Do you mean something like this:  AC_SYS_LARGEFILE
(https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/System-Services.html)?

>> Signed-off-by: Peter Korsgaard <jacmet at sunsite.dk>
>> Signed-off-by: Yegor Yefremov <yegorslists at googlemail.com>
>> ---
>>  vmcore-dmesg/vmcore-dmesg.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/vmcore-dmesg/vmcore-dmesg.c b/vmcore-dmesg/vmcore-dmesg.c
>> index f47ee11..9bb1cc2 100644
>> --- a/vmcore-dmesg/vmcore-dmesg.c
>> +++ b/vmcore-dmesg/vmcore-dmesg.c
>> @@ -1,6 +1,4 @@
>>  #define _XOPEN_SOURCE 600
>> -#define _LARGEFILE_SOURCE 1
>> -#define _FILE_OFFSET_BITS 64
>>  #include <endian.h>
>>  #include <byteswap.h>
>>  #include <stdio.h>
>> --
>> 1.8.3.2
>>
>>
>> _______________________________________________
>> kexec mailing list
>> kexec at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/kexec
>>



More information about the kexec mailing list