[v3 0/3] Introduce struct cycle to store cyclic region and clean up

Atsushi Kumagai kumagai-atsushi at mxc.nes.nec.co.jp
Mon Feb 10 02:58:04 EST 2014


On 2014/02/08 18:21:05, Baoquan He <bhe at redhat.com> wrote:
> v1->v2:
>     In first_cycle(), start_pfn assignation is not aligned to info->pfn_cyclic.
>     Now in v2 change this. Accordingly the pfn in write_elf_header() and
>     write_elf_pages_cyclic() need be adjusted to the real beginning of a
>     load segment, but not the cycle->start_pfn which may be lower after alignment.
> 
> v2->v3:
>     Astushi and HATAYAMA found removing the pfn check in set_bitmap_cyclic will
> introduce bugs. So it's better to add the pfn checking back, though there's
> a little influence on perforcemance.

Thanks, I'll merge this version into v1.5.6.

Atsushi Kumagai

> Baoquan He (3):
>   makedumpfile: introduce struct cycle to store the cyclic region
>   makedumpfile: use struct cycle to update cyclic region and clean up
>   makedumpfile: remove member variables representing cyclic pfn region
>     in struct DumpInfo
> 
>  makedumpfile.c | 498 ++++++++++++++++++++++++++++-----------------------------
>  makedumpfile.h |  21 +--
>  sadump_info.c  |   4 +-
>  3 files changed, 261 insertions(+), 262 deletions(-)
> 
> -- 
> 1.8.3.1
> 
> 



More information about the kexec mailing list