[PATCH] makedumpfile: add missing options to man page or help

Atsushi Kumagai kumagai-atsushi at mxc.nes.nec.co.jp
Fri Jun 21 03:31:32 EDT 2013


On Fri, 21 Jun 2013 14:25:03 +0800
Baoquan <bhe at redhat.com> wrote:

> > BTW, we can assign non-printable characters as short options. Normally
> > we don't type non-printable characters on console, so it's for free.
> > 
> 
> Hi,
> I think it's good idea. In kexec, some options use below short option
> with a large value. With these indicative MACRO as short option, it will
> make code more readable.
> 
> Then all old short options can be replaced with them.
> 
> #define OPT_MEM_MIN             256
> #define OPT_MEM_MAX             257
> #define OPT_REUSE_INITRD        258
> #define OPT_LOAD_PRESERVE_CONTEXT 259
> #define OPT_LOAD_JUMP_BACK_HELPER 260
> #define OPT_ENTRY               261
> #define OPT_MAX                 262

OK, let's adopt it.


Thanks
Atsushi Kumagai



More information about the kexec mailing list