makedumpfile-1.5.2: Secret data scrubbing with eppic language.

[Dave Young]

On 02/18/2013 12:14 PM, Atsushi Kumagai wrote:
> Hello Dave,
> 
> On Sat, 16 Feb 2013 18:03:38 +0800
> Dave Young <dyoung at redhat.com> wrote:
> 
>> On 02/14/2013 10:07 AM, Atsushi Kumagai wrote:
>>> Hello,
>>>
>>> makedumpfile version 1.5.2 is released.
>>> Your comments/patches are welcome.
>>
>> Hi,
>> ppc64 build fails with "undefined reference to readpage_sadump".
>>
> 
> Thanks for reporting this issue.
> 
> readpage_sadump() was introduced as modification of readpmem_sadump
> to use caching feature, but the dummy implementation of it wasn't
> renamed.
> 
> I'll fix this issue with the patch below, so could you test it in your
> environment ?

Hi, Atsushi

It works for me, thanks.

Tested-by: Dave Young <dyoung at redhat.com>

> 
> 
> Thanks
> Atsushi Kumagai
> -----------------------------------------------------------------
> 
> [PATCH] Fix dummy implementation for readpage_sadump.
> 
> readpage_sadump() was introduced as modification of readpmem_sadump,
> but the dummy implementation of it wasn't renamed.
> 
> Signed-off-by: Atsushi Kumagai <kumagai-atsushi at mxc.nes.nec.co.jp>
> 
> diff --git a/sadump_info.h b/sadump_info.h
> index 766f35d..c0175dd 100644
> --- a/sadump_info.h
> +++ b/sadump_info.h
> @@ -97,8 +97,8 @@ static inline unsigned long long sadump_get_max_mapnr(void)
>         return 0;
>  }
> 
> -static inline int readpmem_sadump(unsigned long long paddr,
> -                                 void *bufptr, size_t size)
> +static inline int
> +readpage_sadump(unsigned long long paddr, void *bufptr)
>  {
>         return FALSE;
>  }
> 
> 
>> Below patch fixes this, but feel free to fix it without the #if in other way.
>>
>> diff -uprN makedumpfile/makedumpfile.c makedumpfile.new/makedumpfile.c
>> --- makedumpfile/makedumpfile.c	2013-02-16 17:58:58.158576503 +0800
>> +++ makedumpfile.new/makedumpfile.c	2013-02-16 17:59:19.775577017 +0800
>> @@ -412,9 +412,11 @@ readmem(int type_addr, unsigned long lon
>>  		if (info->flag_refiltering) {
>>  			if (!readpage_kdump_compressed(pgaddr, pgbuf))
>>  				goto error;
>> +#if defined(__x86__) || defined(__x86_64__)
>>  		} else if (info->flag_sadump) {
>>  			if (!readpage_sadump(pgaddr, pgbuf))
>>  				goto error;
>> +#endif
>>  		} else {
>>  			if (!readpage_elf(pgaddr, pgbuf))
>>  				goto error;
> 
> _______________________________________________
> kexec mailing list
> kexec at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 


-- 
Thanks
Dave