[PATCH] makedumpfile: reverse -c and -p if using snappy compression

WANG Chao chaowang at redhat.com
Wed Aug 28 22:58:37 EDT 2013


Hi, Cliff

On 08/28/13 at 05:08pm, Cliff Wickman wrote:
> From: Cliff Wickman <cpw at sgi.com>
> 
> Reverse the meanings of -c (compression) and -p (snappy compression) if
> USESNAPPY is defined.
> 
> The distro kdump scripts seem to only support -c for compression.
> So make -c mean snappy compression if it is supported.

It looks like more a distro issue to me. I'm wondering if that script
only support -c, why do that distro compile makedumpfile with USESNAPPY?

I don't think other distros would like to see this change. IMHO, the
right thing to do is fix that kdump script on that particular distro,
not reverse -c and -p.

Thanks
WANG Chao



More information about the kexec mailing list