[PATCH] makedumpfile-1.5.4 "make install" assumes directories exist

[Atsushi Kumagai]

On Tue, 6 Aug 2013 08:36:28 -0700
Nick Bartos <nick at pistoncloud.com> wrote:

> Yes that makes sense, /usr/sbin sounds good.

Thanks for your reply.
The fixed patch will be merged into v1.5.5.


Atsushi Kumagai
 
> 
> On Mon, Aug 5, 2013 at 9:15 PM, Atsushi Kumagai <
> kumagai-atsushi at mxc.nes.nec.co.jp> wrote:
> 
> > Hello Nick,
> >
> > On Mon, 29 Jul 2013 09:31:55 -0700
> > Nick Bartos <nick at pistoncloud.com> wrote:
> >
> > > The make install of makedumpfile-1.5.4 uses cp instead of the usual
> > > "install" command, which has some side effects of not pre-creating
> > > directories.  This results in installs to an alternate DESTDIR fail
> > because
> > > the parent directories do not exist.
> > >
> > > I have attached a patch which modifies make install to use the install
> > > utility.
> > >
> > > ---
> > > diff -U3 -r makedumpfile-1.5.4.orig/Makefile makedumpfile-1.5.4/Makefile
> > > --- makedumpfile-1.5.4.orig/Makefile  2013-07-01 08:08:49.000000000 +0000
> > > +++ makedumpfile-1.5.4/Makefile       2013-07-18 17:15:01.109058204 +0000
> > > @@ -86,8 +86,8 @@
> > >       rm -f $(OBJ) $(OBJ_PART) $(OBJ_ARCH) makedumpfile
> > makedumpfile.8.gz makedumpfile.conf.5.gz
> > >
> > >  install:
> > > -     cp makedumpfile ${DESTDIR}/bin
> > > -     cp makedumpfile-R.pl ${DESTDIR}/bin
> > > -     cp makedumpfile.8.gz ${DESTDIR}/usr/share/man/man8
> > > -     cp makedumpfile.conf.5.gz ${DESTDIR}/usr/share/man/man5
> > > -     cp makedumpfile.conf ${DESTDIR}/etc/makedumpfile.conf.sample
> > > +     install -m 755 -d ${DESTDIR}/usr/bin ${DESTDIR}/usr/share/man/man5
> > ${DESTDIR}/usr/share/man/man8 ${DESTDIR}/etc
> > > +     install -m 755 -t ${DESTDIR}/usr/bin makedumpfile makedumpfile-R.pl
> > > +     install -m 644 -t ${DESTDIR}/usr/share/man/man8 makedumpfile.8.gz
> > > +     install -m 644 -t ${DESTDIR}/usr/share/man/man5
> > makedumpfile.conf.5.gz
> > > +     install -m 644 -D makedumpfile.conf
> > ${DESTDIR}/etc/makedumpfile.conf.sample
> >
> > I think /usr/sbin is better than /usr/bin as installation directory
> > according to Filesystem Hierarchy Standard.
> >
> >   4.10. /usr/sbin : Non-essential standard system binaries
> >   4.10.1. Purpose
> >
> >     This directory contains any non-essential binaries used exclusively
> >     by the system administrator. System administration programs that are
> >     required for system repair, system recovery, mounting /usr, or other
> >     essential functions must be placed in /sbin instead.
> >
> > So may I fix that when I merge this patch ?
> >
> >
> > Thanks
> > Atsushi Kumagai