[PATCH] makedumpfile: s390x: Allow HW Change-bit override for page table entries

Atsushi Kumagai kumagai-atsushi at mxc.nes.nec.co.jp
Mon Nov 19 22:55:28 EST 2012


Hello Michael,

On Fri, 16 Nov 2012 14:34:58 +0100
Michael Holzheu <holzheu at linux.vnet.ibm.com> wrote:

> The HW Change-bit override (0x100) is used now for s390x. This patch allows
> page table entries that have set this bit.
> 
> Signed-off-by: Michael Holzheu <holzheu at linux.vnet.ibm.com>

Thanks for your work.
I will merge this patch into v1.5.2.


Thanks
Atsushi Kumagai

> ---
>  arch/s390x.c   |    4 ++--
>  makedumpfile.h |    1 -
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> --- a/arch/s390x.c
> +++ b/arch/s390x.c
> @@ -195,10 +195,10 @@ static ulong _kl_pg_table_deref_s390x(un
>  	readmem(VADDR, table + offset, &entry, sizeof(entry));
>  	/*
>  	 * Check if the page table entry could be read and doesn't have
> -	 * any of the reserved bits set.
> +	 * the reserved bit set.
>  	 * Check if the page table entry has the invalid bit set.
>  	 */
> -	if (entry &  (_PAGE_CO | _PAGE_ZERO | _PAGE_INVALID)) {
> +	if (entry &  (_PAGE_ZERO | _PAGE_INVALID)) {
>  		ERRMSG("Invalid page table entry.\n");
>  		return 0;
>  	}
> --- a/makedumpfile.h
> +++ b/makedumpfile.h
> @@ -575,7 +575,6 @@ do { \
>  #define _SEGMENT_INDEX_SHIFT	20
>  
>  /* Hardware bits in the page table entry */
> -#define _PAGE_CO		0x100	/* HW Change-bit override */
>  #define _PAGE_ZERO		0x800	/* Bit pos 52 must conatin zero */
>  #define _PAGE_INVALID		0x400	/* HW invalid bit */
>  #define _PAGE_INDEX_SHIFT	12
> 
> 
> _______________________________________________
> kexec mailing list
> kexec at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec



More information about the kexec mailing list