[PATCH v2 09/10] Add page_is_buddy for old kernels

HATAYAMA Daisuke d.hatayama at jp.fujitsu.com
Fri Nov 16 00:02:18 EST 2012


On kernels from v2.6.15 to v2.6.17, buddy page is marked by the
condition that PG_private flag is set and _count == 0.

Since this page_is_buddy needs _count, we use freelist logic if _count
is not available.

Unfortunately, I have yet to test this logic on these kernel versions
simply because I've been failing to boot them on my box.

Note that on these kernels, free list can be corrupted due to the bug
that the above two conditions are not checked atomically. The reason
why PG_buddy was introduced is a fix for this bug.

Signed-off-by: HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com>
---

 makedumpfile.c |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/makedumpfile.c b/makedumpfile.c
index 4e5d4d3..65b9fd7 100644
--- a/makedumpfile.c
+++ b/makedumpfile.c
@@ -3669,6 +3669,20 @@ exclude_free_page(void)
 }
 
 /*
+ * For the kernel versions from v2.6.15 to v2.6.17.
+ */
+static int
+page_is_buddy_v1(unsigned long flags, unsigned int _mapcount,
+			unsigned long private, unsigned int _count)
+{
+	if ((flags & (1UL << NUMBER(PG_private)))
+	    && _count == 0)
+		return TRUE;
+
+	return FALSE;
+}
+
+/*
  * For the kernel versions from v2.6.17 to v2.6.37.
  */
 static int
@@ -3707,6 +3721,9 @@ setup_page_is_buddy(void)
 		if (NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE) != NOT_FOUND_NUMBER) {
 			if (OFFSET(page._mapcount) != NOT_FOUND_STRUCTURE)
 				info->page_is_buddy = page_is_buddy_v3;
+		} else if (SIZE(pageflags) == NOT_FOUND_STRUCTURE) {
+			if (OFFSET(page._count) != NOT_FOUND_STRUCTURE)
+				info->page_is_buddy = page_is_buddy_v1;
 		}
 	} else
 		info->page_is_buddy = page_is_buddy_v2;




More information about the kexec mailing list