[PATCH v2] kexec-tools, ppc64: Fix segfault parsing DR memory property

Simon Horman horms at verge.net.au
Tue May 18 20:22:27 EDT 2010


On Tue, May 18, 2010 at 09:30:32AM +1000, Michael Neuling wrote:
> 
> 
> In message <4BECBE89.3020108 at ozlabs.org> you wrote:
> > add_dyn_reconf_usable_mem_property() iterates over memory spans
> > in /ibm,dynamic-reconfiguration-memory/ibm,dynamic-memory and intersects
> > these with usablemem_rgns ranges.  In doing so it used an unchecked
> > fixed-size array which will overrun on machines with lots of LMBs.
> > 
> > This patch removes the fixed-sized arrays from
> > add_dyn_reconf_usable_mem_property() and add_usable_mem_property(), in lieu o
> f
> > malloc/realloc/free.
> > 
> > Signed-off-by: Matt Evans <matt at ozlabs.org>
> 
> So this works our large P7 machine unlike the last one.
> 
> Acked-by: Michael Neuling <mikey at neuling.org>

Thanks, applied



More information about the kexec mailing list